deltas: Don't put unreadable *from* objects in fallback
authorColin Walters <walters@verbum.org>
Fri, 10 Feb 2017 21:05:17 +0000 (16:05 -0500)
committerAtomic Bot <atomic-devel@projectatomic.io>
Fri, 17 Feb 2017 14:58:25 +0000 (14:58 +0000)
commit98a45475107d507d85d946e934be9064fe2efcf7
tree7db788cf87f21b86b811ea1445d7a40091938268
parenta1805d6101eb8efeaa72459c22d88ed08ff7a065
deltas: Don't put unreadable *from* objects in fallback

In https://github.com/ostreedev/ostree/pull/634 we introduced
a subtle regression - the unreadable object was added to the *new*
reachable objects, when it shouldn't have been.  Because it
was a *from* object, clients already had it.

This became more obvious now that I'm working on fixing delta
progress - I noticed my deltas were always starting out with 40MB
fetched, which turned out to be a non-world-readable initramfs object.

This code should simply *skip* the unreadable object, and the delta processing
below properly iterates over "new objects", so we'll pick it up from there.

Closes: #678
Approved by: giuseppe
src/libostree/ostree-repo-static-delta-compilation.c